Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Update script still looking for SteamPrefill #10

Closed
MrMdemiC opened this issue Feb 13, 2023 · 8 comments
Closed

[Bug] Update script still looking for SteamPrefill #10

MrMdemiC opened this issue Feb 13, 2023 · 8 comments

Comments

@MrMdemiC
Copy link

Hi, was trying to get this prefill working but before starting the program i started the update.sh script
I was presented with an error so i took a look into the script and found that the #unzip and below it is still looking for SteamPrefill instead off EpicPrefill:
# Unzip
echo -e "${Yellow} Unzipping... ${NC}"
unzip -q -j -o SteamPrefill-${LATEST_TAG}-linux-x64.zip

# Required so executable permissions don't get overwritten by unzip
chmod +x SteamPrefill update.sh

# Cleanup
rm SteamPrefill-${LATEST_TAG}-linux-x64.zip

When i change the SteamPrefill to EpicPrefill the script runs without errors :)

@Velosofy
Copy link

Feel free to make a PR :D

@Joly0 Joly0 closed this as completed in 0657902 Feb 13, 2023
@Joly0
Copy link
Collaborator

Joly0 commented Feb 13, 2023

Closed this accidentially.
@MrMdemiC Can you test and confirm its correct now?

@MrMdemiC
Copy link
Author

Feel free to make a PR :D

if i knew how i would love to do it hahahah :P

Closed this accidentially. @MrMdemiC Can you test and confirm its correct now?

i dont think it will work since the release is not updated as off this moment off writing this comment :)

when the release is updated i will test again <3

@Joly0
Copy link
Collaborator

Joly0 commented Feb 13, 2023

Feel free to make a PR :D

if i knew how i would love to do it hahahah :P

Closed this accidentially. @MrMdemiC Can you test and confirm its correct now?

i dont think it will work since the release is not updated as off this moment off writing this comment :)

when the release is updated i will test again <3

You can take the file from here
https://github.com/tpill90/epic-lancache-prefill/suites/10954170053/artifacts/554422811

@MrMdemiC
Copy link
Author

Feel free to make a PR :D

if i knew how i would love to do it hahahah :P

Closed this accidentially. @MrMdemiC Can you test and confirm its correct now?

i dont think it will work since the release is not updated as off this moment off writing this comment :)
when the release is updated i will test again <3

You can take the file from here https://github.com/tpill90/epic-lancache-prefill/suites/10954170053/artifacts/554422811

this one kinda works 1 time but it looks at the latest release and downloads that one and overrides it...
so yes it works but only one time :)

@MrMdemiC
Copy link
Author

BTW thanks for the help,, i am no expert in GitHub but just want to help with these small kinda things :D

@MrMdemiC
Copy link
Author

also clicking that link downloads zip file named SteamPrefill :)

i understand that this is made quickly and still needs alot off name changing but just pointing out small things ;)

@tpill90
Copy link
Owner

tpill90 commented Mar 15, 2023

Released in v1.1.0

@tpill90 tpill90 closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants