-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack Smashing Detected error on tpm2_createpolicy 3.2.0 #1632
Comments
This is the same issue as #778: it is not possible to use more than 8 PCRs due to limitations of the TPM 2.0 specification. Of course
I have therefore opened #1633 to backport this fix to the 3.X branch as well. |
This was already reported for tpm2-tools-3.1.4-1.fc30.x86_64 in #1389, but the commit 9685ea2 referenced there doesn't seem to be sufficient to fix the issue: I can reproduce the crash with the Fedora binaries as well as with my self-compiled binaries based on the current 3.X branch. After applying the fix in #1633, the program exits cleanly with an error message instead of crashing. |
We should also probably add a test for this... |
@williamcroberts yes, there is no crash now. |
@dnoliver I think the parser logic is limited to 8 pcrs as @martinezjavier mentioned. We could improve the parser to not suck, if someone wants to do that. |
Clevis with
tpm2-tools-3.1.4-1.fc29.x86_64
worked fine, as noted in latchset/clevis#102Clevis with
tpm2-tools-3.2.0-1.fc30.x86_64
is running into this issue, as noted in latchset/clevis#109Error Message
Versions
@martinezjavier suggested that this is a problem with the
tpm2_createpolicy
command in latchset/clevis#109 (comment)I remember that there was some build with "hardening" enabled done lately, could that be causing this issue?
The text was updated successfully, but these errors were encountered: