Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python3 for tpm2-tools v4 #1708

Closed
nullr0ute opened this issue Aug 27, 2019 · 5 comments
Closed

Support python3 for tpm2-tools v4 #1708

nullr0ute opened this issue Aug 27, 2019 · 5 comments

Comments

@nullr0ute
Copy link

Python is used in a couple of places, primarily in the tests, but also in some of the configure checks for the build. With python2 going EOL at the end of this year and a lot of Linux distros actively moving to python3 as their default (or not shipping a /usr/bin/python binary) the tpm2-tools should detect and work with python3

@williamcroberts
Copy link
Member

Sorry this won't happen for 4.0, but we can look into it for 4.0.x or a 4.1.x release. But this is something we need to do, as you mention python2 is going away.

@diabonas
Copy link
Member

The scripts themselves are compatible with Python 3 already, I think this would be only a matter of changing all invocations of python to python3, since that should work on all recent major distributions. Probably this can wait until after Python 2 is EOL, since I believe most distributions still have /usr/bin/python, and we don't care whether it is a symlink to python2 or python3.

@williamcroberts
Copy link
Member

@diabonas I was just testing this and found the same thing. We already have python3 support. We should probably do one of the follwing:

  • ci test for python2 and python3
  • change python to python3 <-- I support this

Any arguments to keep python 2.x support around since its EOL?

@williamcroberts
Copy link
Member

@diabonas I was just testing this and found the same thing. We already have python3 support. We should probably do one of the follwing:

  • ci test for python2 and python3
  • change python to python3 <-- I support this

Any arguments to keep python 2.x support around since its EOL?

I guess ubuntu18.04 has it be default so we could keep testing it if we switch to multiple distros to test against we'll pick up python3 in fedora 30.

@williamcroberts
Copy link
Member

This is all being tested now and works with python3 and python2. The CI scripts are building on multiple distros each using a different flavor of python, see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants