Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling logic when reporting invalid command line options. #16

Open
tpn opened this issue Jan 29, 2019 · 0 comments
Open

Fix error handling logic when reporting invalid command line options. #16

tpn opened this issue Jan 29, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tpn
Copy link
Owner

tpn commented Jan 29, 2019

How to reproduce the problem (using --NoFile as an argument instead of the correct --NoFileIo):

C:\perfecthash\src> timemem .\x64\Release\PerfectHashCreate.exe C:\Temp\Events-1894.keys
c:\temp\output Chm01 Crc32RotateWXYZ And 1 --NoFile
Invalid command line argument: NoFile
c:\perfecthash\src\perfecthash\perfecthasherrorhandling.c: 220: FormatMessageA failed with error: 234 (0xea).  More data is available.

I'm doing something quirky with FormatMessage when expansion args are present in the format string. Haven't yet investigated.

@tpn tpn added bug Something isn't working good first issue Good for newcomers labels Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant