Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to slf4j 2.0? #1885

Open
jatcwang opened this issue Jun 20, 2023 · 1 comment
Open

Upgrade to slf4j 2.0? #1885

jatcwang opened this issue Jun 20, 2023 · 1 comment

Comments

@jatcwang
Copy link
Collaborator

At some point HikariCP uses slf4j 2.0.0-alpha1 (see #1498), and as of writing the latest version 5.0.1 is was published to use 2.0.0-alpha1.

However seems like the HikariCP author has reverted that change in latest dev branch as the pom.xml no longer has any references to slf4j 2.x (https://github.com/brettwooldridge/HikariCP/blob/dev/pom.xml, or https://github.com/brettwooldridge/HikariCP/blob/2e07be7b325b05f7225611c60f421e253e1107a5/pom.xml at time of writing)

slf4j 2.0 upgrade should wait until HikariCP (the only library that's causing doobie to pull in slf4j) publishes a non-alpha release of slf4j 2.x

@Daenyth
Copy link
Collaborator

Daenyth commented Jun 20, 2023

Even then, if they upgrade but don't invoke any of the new apis, it might be prudent to wait for as long as possible, to avoid disrupting the rest of the ecosystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants