Skip to content

Commit

Permalink
Fix confusing negative in contribution guidelines
Browse files Browse the repository at this point in the history
  • Loading branch information
tpope committed Apr 5, 2018
1 parent f4fd604 commit 06da921
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions CONTRIBUTING.markdown
@@ -1,7 +1,7 @@
Follow the commit message guidelines at [commit.style](https://commit.style). Follow the commit message guidelines at [commit.style](https://commit.style).
This is an absolute requirement for my repositories, and furthermore this This is an absolute requirement for my repositories, and doing so proves you
proves you didn't actually read the contribution guidelines, which doesn't actually read the contribution guidelines, which makes for a good first
make for a great first impression. impression.


Good commit messages imply good commits. Pull requests should typically be a Good commit messages imply good commits. Pull requests should typically be a
single commit, or for the rare complicated case, a series of atomic commits. single commit, or for the rare complicated case, a series of atomic commits.
Expand Down

2 comments on commit 06da921

@theasteve
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tpope how you add the context to a commit message? I'm trying to get past the git commit -m < Less than 50 characters message>"

@tpope
Copy link
Owner Author

@tpope tpope commented on 06da921 Jan 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t use -m, let it spawn your editor.

Please sign in to comment.