RememberMe.loginWithPassword argument types

[evg1n]

Hello,

I think it would be a better practice to change argument type "username" from String to String or Object, because it is as such in Meteor.loginWithPassword( username || email [Type: String or Object], password, callback).

Because, some websites do not have username implementation and logs in only with email. So when you use (email, password) => Meteor.loginWithPassword({email: email}, password, [callback]) it works.

IMHO you should also implement this argument type to your RememberMe class.

Nice add-on, keep up the good work!

[tprzytula]

Hi evg1n,

That's a really good point!

I've completely missed the fact that you can use email in the initial implementation and introduced the fix for it to work in the 1.0.1 version. However, I did not update the documentation and JSDoc accordingly. Will make sure to do that when I will find some time this week.

Thanks a lot!

[tprzytula]

I've updated the code & docs with the fixes. They are now following the same wording as the official Meteor documentation & code does.