Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gh links in gh release notes #184

Closed
tpvasconcelos opened this issue Apr 19, 2024 · 1 comment
Closed

Fix gh links in gh release notes #184

tpvasconcelos opened this issue Apr 19, 2024 · 1 comment
Labels
CI Related to CI checks good first issue Good for newcomers

Comments

@tpvasconcelos
Copy link
Owner

The new release notes are not rendered correctly in the GitHub releases. See v0.1.25 for instance.

A simple solution would be to hard-code some regex logic in extract_latest_release_notes.py to deal specifically with this conversion:

{gh-issue}`123` --> [#123](https://github.com/tpvasconcelos/ridgeplot/pull/123)
@tpvasconcelos tpvasconcelos added good first issue Good for newcomers CI Related to CI checks labels Apr 19, 2024
@tpvasconcelos tpvasconcelos mentioned this issue Jun 7, 2024
Merged
@tpvasconcelos
Copy link
Owner Author

Fixed in #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Related to CI checks good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpvasconcelos