Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage #714

Closed
wants to merge 1 commit into from
Closed

Fix usage #714

wants to merge 1 commit into from

Conversation

JaviMerino
Copy link
Contributor

You can't import tqdm_notebook. You either import tnrange() from tqdm or ._tqdm_notebook.

  • I have visited the source website, and in particular
    read the known issues
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and
    environment, where applicable: 
    import tqdm, sys
print(tqdm.__version__, sys.version, sys.platform)
  • If applicable, I have mentioned the relevant/related issue(s)

@JaviMerino
Fix usage
f733253 
You can't import `tqdm_notebook`. You either import `tnrange()` from `tqdm` or `._tqdm_notebook`.
@codecov-io
Copy link

Codecov Report

Merging #714 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files          10       10           
  Lines         773      773           
  Branches      140      140           
=======================================
  Hits          762      762           
  Misses          6        6           
  Partials        5        5

@casperdcl casperdcl self-assigned this May 16, 2019
@casperdcl casperdcl added question/docs ‽ Documentation clarification candidate to-merge ↰ Imminent labels May 16, 2019
@casperdcl casperdcl changed the base branch from master to devel June 18, 2019 17:46
casperdcl pushed a commit that referenced this pull request Jun 18, 2019
@JaviMerino @casperdcl
Fix usage
228178c 
Can't import `tqdm_notebook`.
Either import `tnrange()` from `tqdm` or `._tqdm_notebook`.

- closes #714
@casperdcl
Copy link
Sponsor Member

casperdcl commented Jun 18, 2019 •
edited

merged in e52835d

@casperdcl casperdcl closed this Jun 18, 2019
casperdcl pushed a commit that referenced this pull request Jun 18, 2019
@JaviMerino @casperdcl
Fix usage docstrings
e52835d 
- replace `tqdm_notebook` with `tqdm.tnrange()` (or `._tqdm_notebook`)
- replace `tqdm_gui` with `tqdm.tgrange` (or `._tqdm_gui`)
- closes #714
- closes #715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@casperdcl casperdcl

Labels
question/docs ‽ Documentation clarification candidate to-merge ↰ Imminent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JaviMerino @codecov-io @casperdcl