Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trim on overflow #850

Merged
merged 5 commits into from Dec 19, 2019
Merged

trim on overflow #850

merged 5 commits into from Dec 19, 2019

Conversation

casperdcl
Copy link
Sponsor Member

@casperdcl casperdcl commented Nov 23, 2019 •
edited

@casperdcl casperdcl self-assigned this Nov 23, 2019
@casperdcl casperdcl changed the base branch from master to devel November 23, 2019 02:02
@casperdcl casperdcl changed the title Fixed width bar trim on overflow Nov 23, 2019
@casperdcl casperdcl added p2-bug-warning ⚠ Visual output bad p3-enhancement 🔥 Much new such feature to-fix ⌛ In progress labels Nov 23, 2019
@casperdcl casperdcl added this to Next Release in Casper Nov 23, 2019
@casperdcl casperdcl added this to the v5.0.0 milestone Nov 23, 2019
James E. King III and others added 4 commits December 19, 2019 20:03
@casperdcl
Implement fixed width bar [bar_width] and chop overflow of ncols
74a645b 
- added bar_width to initializer and format_meter that sets a fixed
  bar width that never changes (unless:)
- added better ncols handling for overflows on l_bar, bar, r_bar
  specifically, output is restricted to one line (of length ncols)
  and will be chopped to ensure that is always true
- added tests

This fixes #623
This fixes #690
This helps prevent the spillover seen in #630
@casperdcl
tidy wip
bef86db
@casperdcl
fix most tests and logic
127af5c
@casperdcl
style fixes
cb723a4
@casperdcl casperdcl merged commit 4f0ed9e into devel Dec 19, 2019
Casper automation moved this from Next Release to Done Dec 19, 2019
casperdcl added a commit that referenced this pull request Dec 19, 2019
@casperdcl
Merge branch 'fixed-width-bar' into devel
680d1aa 
- closes #850
- closes #716
- fixes #690
- related to #623
- helps avoid #630
@casperdcl casperdcl deleted the fixed-width-bar branch December 19, 2019 20:46
@casperdcl casperdcl restored the fixed-width-bar branch December 19, 2019 20:46
@casperdcl casperdcl deleted the fixed-width-bar branch December 19, 2019 20:47
@casperdcl casperdcl mentioned this pull request Dec 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@casperdcl casperdcl

Labels
p2-bug-warning ⚠ Visual output bad p3-enhancement 🔥 Much new such feature to-fix ⌛ In progress
Projects
Casper
  
Done
Milestone
Non-breaking
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@casperdcl