Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnitaryHACK] Implemented BBM92.py #109

Merged
merged 3 commits into from May 21, 2021

Conversation

pritamsinha2304
Copy link
Contributor

Tried to implement the BBM92 QKD protocol. I have focused on the key part only.

NOTE: I am trying these QKD protocols by learning, reading papers, watching videos and then trying it to implement it in code. So if there is some mistake in the code and also if there is mistake in my concept or I have understood the concept wrongly, please do tell me. I am also learning.

Copy link
Collaborator

@stephendiadamo stephendiadamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the path to examples/QKD/...? Then it'll go into the other QKD examples already implemented.

Otherwise looks good.

@stephendiadamo
Copy link
Collaborator

If you like, you can also consider writing a page in the documentation for your example and it can go online in the demonstrations.

@stephendiadamo stephendiadamo merged commit 4569d36 into tqsd:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants