Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompability with VulkanMod #1

Closed
andreasdc opened this issue Jun 26, 2022 · 21 comments
Closed

Incompability with VulkanMod #1

andreasdc opened this issue Jun 26, 2022 · 21 comments
Labels
bug Something isn't working fabric Issue is fabric related wontfix This will not be worked on

Comments

@andreasdc
Copy link

andreasdc commented Jun 26, 2022

When playing on VulkanMod you see all of the textures on the screen. Screen options also are buggy on it.

@tr7zw
Copy link
Owner

tr7zw commented Jun 26, 2022

Yea, from what I can tell it's a bug/inconsistency on VulkanMods end, but I also later had to add some dirty hacks for the blend issues, that might not translate well to VulkanMod. I know that it renders correctly internally but then puts the wrong texture onto the screen. @xCollateral might need to take a look at it.

@andreasdc
Copy link
Author

When playing on VulkanMod you see all of the textures on the screen. Screen options also are buggy on it.

All right, it will be awesome to have this fixed, your mods + VulkanMod is finally playable minecraft. 🚀 ❤️

@andreasdc
Copy link
Author

andreasdc commented Jul 3, 2022

Yea, from what I can tell it's a bug/inconsistency on VulkanMods end, but I also later had to add some dirty hacks for the blend issues, that might not translate well to VulkanMod. I know that it renders correctly internally but then puts the wrong texture onto the screen. @xCollateral might need to take a look at it.

No chance that you would solve this? 🚀 With fastergui I have more fps than on Vulkan :P

@tr7zw
Copy link
Owner

tr7zw commented Jul 3, 2022

See my comment, not much I can do about this, since I have 0 Vulkan experience(and not too much OpenGL experience for that matter).

@andreasdc
Copy link
Author

Any updates?

@tr7zw
Copy link
Owner

tr7zw commented Jul 24, 2022

It's up to @xCollateral . I can't do much other than provide debug output and tools.

@andreasdc
Copy link
Author

Can you help him a bit? VulkanMod needs FasterGUI, it's really massive improvement.

@andreasdc
Copy link
Author

@tr7zw hey can you check the issue here and talk with xCollateral? xCollateral/VulkanMod#60

@tr7zw
Copy link
Owner

tr7zw commented Aug 2, 2022

I don't think this is currently a high prio issue for him or me.

@andreasdc
Copy link
Author

How can it not be if it gives such huge difference? Collateral answered me today, so there is interest

@BitesizedLion
Copy link

BitesizedLion commented Aug 2, 2022

How can it not be if it gives such huge difference? Collateral answered me today, so there is interest

They decide if it is or isn't, and just because he answered doesn't mean interest.
If you want it so badly, fix it yourself.

@andreasdc
Copy link
Author

It actually means that. I don't understand why don't you want to implement 300% fps boost.

@tr7zw
Copy link
Owner

tr7zw commented Aug 2, 2022

Because I currently need to fix all my mods for 1.19 forge, ~38 open todos on the other mods(https://github.com/users/tr7zw/projects/1), a few mods that are missing 1.19 versions in general, vulkan mod is an experimental early version mod with currently 1.6k downloads(on cf), there are important issues with the new features combined with iris, and this mod not even released.
So in the grand scheme of things, this is nice to fix for the future, but fixing 1.19 mods has a priority for me right now. When xCollateral gets around to looking into this issue, I can certainly help him with it. But with my experience in Vulkan/OpenGL, there is literally nothing I can do about it.

@andreasdc
Copy link
Author

I understand, Vulkan has first steps in mod community, xCollateral said: "I think it is a framebuffer issue.", I really want to see FasterGUI with VulkanMod, because without it there is lower performance than with just FasterGUI.

@tr7zw tr7zw added bug Something isn't working wontfix This will not be worked on fabric Issue is fabric related labels Sep 27, 2022
@tr7zw
Copy link
Owner

tr7zw commented Sep 27, 2022

VulkanMod added their own hud improvements. This won't be tracked anymore for now.

@tr7zw tr7zw closed this as completed Sep 27, 2022
Minecraft Issues automation moved this from On Hold to Done Sep 27, 2022
@andreasdc
Copy link
Author

Sure, but you have tablist and nametag improvements, maybe you could work together?

@tr7zw
Copy link
Owner

tr7zw commented Sep 27, 2022

Not really. This mod doesn't do any real improvements, just patches around the mess. Vulkan mod actually does changes to the hud.

@andreasdc
Copy link
Author

I thought Collateral added just batching of hud, I remember there is huge improvement for nametags and tablist which is heavy in the game.

@tr7zw
Copy link
Owner

tr7zw commented Sep 27, 2022

This issue is not worth talking about right now. If it ever happens, then way further in the future. There is nothing I can do and Colleteral also has better things to do than adding support for a random small beta mod.
That's why the issue is closed.

@Alexander020304
Copy link

if any one is wondering if they put the two mods together because you bored. They do not like each other.
image

@andreasdc
Copy link
Author

if any one is wondering if they put the two mods together because you bored. They do not like each other. image

Unfortunately 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fabric Issue is fabric related wontfix This will not be worked on
Projects
Development

No branches or pull requests

4 participants