Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupをJomonで保持せず、traQのAPIから取ってくるように修正 #561

Open
cskd8 opened this issue Apr 2, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@cskd8
Copy link
Member

cskd8 commented Apr 2, 2022

No description provided.

@cskd8 cskd8 added the enhancement New feature or request label Mar 18, 2023
@comavius comavius self-assigned this May 10, 2024
@mehm8128
Copy link
Member

これって実装されたらグループの作成・削除API消えるのかな

@H1rono
Copy link
Member

H1rono commented May 10, 2024

最終的にこのinterfaceが消える、はず

Jomon/model/group.go

Lines 11 to 23 in 85fb937

type GroupRepository interface {
GetGroups(ctx context.Context) ([]*Group, error)
GetGroup(ctx context.Context, groupID uuid.UUID) (*Group, error)
CreateGroup(ctx context.Context, name string, description string, budget *int) (*Group, error)
UpdateGroup(ctx context.Context, groupID uuid.UUID, name string, description string, budget *int) (*Group, error)
DeleteGroup(ctx context.Context, groupID uuid.UUID) error
GetOwners(ctx context.Context, groupID uuid.UUID) ([]*Owner, error)
AddOwners(ctx context.Context, groupID uuid.UUID, ownerIDs []uuid.UUID) ([]*Owner, error)
DeleteOwners(ctx context.Context, groupID uuid.UUID, ownerIDs []uuid.UUID) error
GetMembers(ctx context.Context, groupID uuid.UUID) ([]*Member, error)
AddMembers(ctx context.Context, groupID uuid.UUID, userIDs []uuid.UUID) ([]*Member, error)
DeleteMembers(ctx context.Context, groupID uuid.UUID, userIDs []uuid.UUID) error
}

@mehm8128
Copy link
Member

予算額の管理はJomon側でしたいので完全には消えなさそう

@H1rono
Copy link
Member

H1rono commented Jun 7, 2024

これ、groupの存在はtraQから持ってきて、それにJomon独自の情報を付け足すってイメージですか? @mehm8128

@H1rono
Copy link
Member

H1rono commented Jun 7, 2024

traQからgroupが消されるとまずくなりそう
過去の入出金を見返そうとした時など

@mehm8128
Copy link
Member

mehm8128 commented Jun 7, 2024

合ってます

traQからgroupが消されるとまずくなりそう

確かにknoQとかtraPortfolioとかどうしてるんだろorどうするんだろ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants