New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oapi-codegenを使う #166
oapi-codegenを使う #166
Conversation
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 54.97% 53.52% -1.45%
==========================================
Files 23 23
Lines 1488 1545 +57
==========================================
+ Hits 818 827 +9
- Misses 656 704 +48
Partials 14 14
Continue to review full report at Codecov.
|
|
なおしました:pray: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
#133 がマージされたらコンフリクト解消してマージしておきます:pray: |
omitemptyなparameterを毎回if文分岐させて代入するのを避ける
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです
ありがとうございます!
Close #139