Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oapi-codegenを使う #166

Merged
merged 34 commits into from Dec 27, 2021
Merged

oapi-codegenを使う #166

merged 34 commits into from Dec 27, 2021

Conversation

ras0q
Copy link
Member

@ras0q ras0q commented Nov 8, 2021

Close #139

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #166 (c281898) into main (44052c5) will decrease coverage by 1.44%.
The diff coverage is 39.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   54.97%   53.52%   -1.45%     
==========================================
  Files          23       23              
  Lines        1488     1545      +57     
==========================================
+ Hits          818      827       +9     
- Misses        656      704      +48     
  Partials       14       14              
Impacted Files Coverage Δ
interfaces/handler/project.go 0.70% <0.00%> (-0.09%) ⬇️
interfaces/handler/util.go 0.00% <0.00%> (ø)
interfaces/repository/project_impl.go 0.00% <ø> (ø)
interfaces/handler/user.go 2.48% <3.70%> (+1.87%) ⬆️
interfaces/handler/event.go 70.58% <83.33%> (-7.19%) ⬇️
interfaces/handler/contest.go 90.45% <96.11%> (-0.85%) ⬇️
interfaces/repository/contest_impl.go 92.61% <100.00%> (ø)
usecases/service/project.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44052c5...c281898. Read the comment docs.

@ras0q
Copy link
Member Author

ras0q commented Nov 8, 2021

  • 自動生成された構造体のコンストラクタを作る
  • EditHogeとは別にAddHogeのSchemaを作る
  • optionalな値はutil/optionalでラップしてrepository層に渡す
  • serverも自動生成する(ある程度はparamをvalidateしてくれるので) //別PRでよさそう

@ras0q ras0q marked this pull request as ready for review November 11, 2021 13:39
@ras0q
Copy link
Member Author

ras0q commented Nov 13, 2021

なおしました:pray:

Copy link
Member

@Hosshii Hosshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@ras0q
Copy link
Member Author

ras0q commented Nov 18, 2021

#133 がマージされたらコンフリクト解消してマージしておきます:pray:

Copy link
Member

@Hosshii Hosshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです
ありがとうございます!

@Hosshii Hosshii merged commit aafb186 into main Dec 27, 2021
@Hosshii Hosshii deleted the feat/oapi-codegen branch December 27, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants