This repository has been archived by the owner on May 1, 2020. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Jul 15, 2019
できる限り早くabortするようにしました |
たぶんこれで問題点ほぼ全部解決できました |
sapphi-red
force-pushed
the
impr/markdown-worker
branch
from
August 3, 2019 06:19
6845033
to
7d0567e
Compare
squashしてrebaseして、WIP外しました 🎉 |
#1009 でconflictさせてしまった…… |
sapphi-red
force-pushed
the
impr/markdown-worker
branch
from
August 3, 2019 07:03
7d0567e
to
96704fa
Compare
しました 👍 |
スマホのほうだと一番上まで遡ってしまうレベルでちょっとまずい気がします |
これで直ったりしますか? |
sapphi-red
force-pushed
the
impr/markdown-worker
branch
2 times, most recently
from
August 4, 2019 12:37
3cddac8
to
5225579
Compare
sapphi-red
force-pushed
the
impr/markdown-worker
branch
from
August 11, 2019 14:07
5225579
to
d25d16a
Compare
sapphi-red
force-pushed
the
impr/markdown-worker
branch
2 times, most recently
from
August 26, 2019 14:54
58cc095
to
e4a3179
Compare
スクロールの改善のところまでrebaseしてそれに合わせました |
sapphi-red
force-pushed
the
impr/markdown-worker
branch
from
September 11, 2019 14:05
e4a3179
to
b42b1ac
Compare
n-inja
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
動きはするのですが、
ソースが闇深すぎるというのと
HMRあたりがおかしな挙動をするので
とりあえずドラフトで
#955 からのブランチです
メモ