Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need tests, in multiple way #171

Open
1 of 2 tasks
kongluoxing opened this issue Mar 2, 2023 · 2 comments
Open
1 of 2 tasks

Need tests, in multiple way #171

kongluoxing opened this issue Mar 2, 2023 · 2 comments
Assignees
@xzchaoo
Labels
enhancement New feature or request

Comments

@kongluoxing
Copy link
Contributor

kongluoxing commented Mar 2, 2023 •
edited by xzchaoo

Describe This Problem

It's hard to contribute without unit tests

Proposal

We may build e2e integration tests first, after that can consider to improve unit tests coverage.

Additional Context

No response
@kongluoxing kongluoxing added the enhancement New feature or request label Mar 2, 2023
@xzchaoo
Copy link
Contributor

xzchaoo commented Mar 2, 2023

@kongluoxing
This is a good idea.
We were aware of this issue before, and I recently added a PR (WIP) to prepare the environment for integration tests.
It is expected that it will take a lot of time to supplement test cases and cultivate the habit of developers to write test cases, which will last for several months.

@xzchaoo xzchaoo self-assigned this Mar 9, 2023
@xzchaoo xzchaoo mentioned this issue Mar 15, 2023
Merged
@xzchaoo
Copy link
Contributor

xzchaoo commented Mar 16, 2023

Hi @kongluoxing . I have opened a PR adding E2E tests to HoloInsight project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xzchaoo xzchaoo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kongluoxing @xzchaoo