Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when doing comments for revision diffs #77

Open
walty8 opened this issue Nov 12, 2018 · 1 comment
Open

Problem when doing comments for revision diffs #77

walty8 opened this issue Nov 12, 2018 · 1 comment

Comments

@walty8
Copy link
Member

walty8 commented Nov 12, 2018

In a revision diff page, with a customised 'from' and 'to' revisions (as we normally batch review a range of changesets), I could still make comments there. However, there are two problems:

  1. the link in the comments page does not get me back to the diff page, instead, it bring me to the latest changeset regarding to the 'to' revision.

  2. the comments in the page have wrong positions.

It seems to be related with the following code in web.py

    def changeset_js_data(self, req, data):
        return {
            'page': 'changeset',
            'revision': data['new_rev'],
            'path': data['reponame'],
            'selectorToInsertAfter': 'div.diff div.diff:last'
        }

Apparently, only the reponame, and last revision is stored, instead of the actual diff. I wonder if it would be possible if the full browser URL is stored inside the 'path' column instead?

@SebDieBln
Copy link

Is this a duplicate of #67?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants