Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit use "full" templates on Telegram #5254

Closed
aruznieto opened this issue Jan 22, 2024 · 5 comments
Closed

Permit use "full" templates on Telegram #5254

aruznieto opened this issue Jan 22, 2024 · 5 comments

Comments

@aruznieto
Copy link

I would like that users can select if they want short or full message in Telegram.

@tananaev
Copy link
Member

You have to provide more details for it to be considered.

@aruznieto
Copy link
Author

I think that it would be interesting to put one variable

notificator.[notificator].messageStyle that can take "short" or "full" value

and inside NotificatorTelegram.java (in this case) at send function (line 89), write

var message = notificationFormatter.formatMessage(notification, user, event, position, config.getString(Keys.NOTIFICATOR_TELEGRAM_MESSAGESTYLE));

@tananaev
Copy link
Member

I think you misunderstood the question. If it's a feature request, we have a template that you have to fill out. Looks like you completely ignored that template and we can't accept a request like this. You have to provide justification for why we should include it and why it would benefit a large number of users.

@aruznieto
Copy link
Author

Ok, i am going to try do it alone, I think that is interesting to give the user the possibility to select the message style that their want

@tananaev
Copy link
Member

OK, I'm going to close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants