Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxPool1D #134

Closed
nathanielsimard opened this issue Dec 25, 2022 · 5 comments
Closed

MaxPool1D #134

nathanielsimard opened this issue Dec 25, 2022 · 5 comments
Assignees
Labels
feature The feature request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nathanielsimard
Copy link
Member

nathanielsimard commented Dec 25, 2022

Feature description

Add MaxPool1D layers.

@nathanielsimard nathanielsimard added the feature The feature request label Dec 25, 2022
@antimora antimora added the help wanted Extra attention is needed label Apr 25, 2023
@nathanielsimard nathanielsimard changed the title MaxPool1D & MeanPool1D MaxPool1D & AvgPool1D May 11, 2023
@antimora antimora changed the title MaxPool1D & AvgPool1D MaxPool1D May 26, 2023
@antimora antimora added the good first issue Good for newcomers label Jul 26, 2023
@caiopiccirillo
Copy link
Contributor

I'd love to contribute to this project, is this issue already in progress or can I give it a try?

@antimora
Copy link
Collaborator

@caiopiccirillo Please go ahead! We have already implemented MaxPool2d. You should probably use it underneath just like Conv1d uses Conv2d but the data is reshaped and the kernel size, among other conf remade to operate on 1d.

@nathanielsimard please confirm this, I am not 100% sure. (Note he's on discord as well, you can chat directly if you have questions).

@antimora
Copy link
Collaborator

@caiopiccirillo I have assigned it to you.

@nathanielsimard
Copy link
Member Author

@caiopiccirillo I don't think anybody is on this. You can look into how avg_pool1d is done, it provide a default implementation so not all backends require to implement the function, but it gives to option to override the default implementation (using the 2d kernel) to improve performance.

Like @antimora mentionned, don't hesite to poke us on Discord if you need help. Good luck!

@caiopiccirillo caiopiccirillo mentioned this issue Aug 7, 2023
1 task
@antimora
Copy link
Collaborator

Completed per #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature The feature request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants