Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: re-write LlamaIndex instrumentation to use LlamaIndex CallbackManager #134

Open
1 task done
nirga opened this issue Mar 7, 2024 · 10 comments
Open
1 task done

Comments

@nirga
Copy link
Member

nirga commented Mar 7, 2024

Which component is this feature for?

LlamaIndex Instrumentation

🔖 Feature description

Right now, we monkey-patch classes and methods in LlamaIndex which requires endless work and constant maintenance. LlamaIndex has a system for callbacks that can potentially be used to create/end spans without being too coupled with with the framework's inner structure.

🎤 Why is this feature needed ?

Support LlamaIndex entirely and be future-proof to internal API changes

✌️ How do you aim to achieve this?

Look into LlamaIndex callback_manager and how other frameworks are using it.

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@kartikay-bagla
Copy link
Contributor

@quest-bot embark

Copy link

quest-bot bot commented Mar 12, 2024

⚠️ There's no active Quest for this Issue.

Check the docs for more info.

@kartikay-bagla
Copy link
Contributor

@nirga I was looking at the LlamaDebugHandler (in the python code) and it looks like in terms of features, I just need to recreate this and extend it to add the existing traces. Does that sound correct?

@nirga
Copy link
Member Author

nirga commented Mar 12, 2024

Yep @kartikay-bagla. It's a bit trickier cause you need to create and close spans accordingly, and make sure to nest them correctly.

@kartikay-bagla
Copy link
Contributor

Yeah, I'll get started on this because I think it'll take some time.

@kartikay-bagla
Copy link
Contributor

Small update, with this being a larger code change than expected, and some unscheduled life things, I might have to put this on hold until the 18th. Will keep you updated though.

@kartikay-bagla
Copy link
Contributor

So I was able to make some progress over the weekend, but it is slow as I couldn't find any existing implementation of callback_manager that I could use as a starting point.

@nirga
Copy link
Member Author

nirga commented Mar 26, 2024

Thanks so much @kartikay-bagla! I've been in touch with the folks at LlamaIndex so ping me here or on slack if you have any questions I can pass along.

@JCaraballo113
Copy link

Hi, I will try to solve this issue. I do have one question. This feature is desired for the JS SDK or the Python SDK or both?

@nirga
Copy link
Member Author

nirga commented May 3, 2024

For both @JCaraballo113 :)
@kartikay-bagla are you still on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants