-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commitment sma support #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sporejack
suggested changes
Nov 1, 2021
sporejack
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need support for arbitrary frontrunning intervals (which can be many factors larger than the
updateInterval
). This requires being able to store data for an arbitrary number of update intervals at a particular point in time.Note that this PR introduces loops, but the amount of iterations still has a limited upper-bound. The upper-bound is
frontRunningInterval / updateInterval
(e.g. if frontRunningInterval = 5 * updateInterval, then there will be at most 5 iterations.Changes
PoolSwapLibrary
appropriateUpdateIntervalId
PoolCommitter
userMostRecentCommit
,userNextIntervalCommit
,totalMostRecentCommit
andtotalNextIntervalCommit
commit
to now store commitment data in the commitment corresponding to the result of a call toPoolSwapLibrary.appropriateUpdateIntervalId
.executeCommitments
now loops through a theoretically unbound number of update intervals (should never actually happen if pool is upkept in a reasonable amount of time.updateAggregateBalance
now loops over all un-aggregated balances. As per the note above, this still has a strict upper bound.getAggregateBalance
has now been updated to reflect the above changes.