Skip to content
This repository has been archived by the owner on Jul 23, 2018. It is now read-only.

Explore replacing pad <use> tags with just the shapes #36

Closed
mcous opened this issue Jan 8, 2017 · 1 comment
Closed

Explore replacing pad <use> tags with just the shapes #36

mcous opened this issue Jan 8, 2017 · 1 comment

Comments

@mcous
Copy link
Member

mcous commented Jan 8, 2017

There's anecdotal evidence that <use> tags slow things down and that nesting them is bad. For every single "pad" shape, gerber-to-svg puts the shape in <defs>, and for every "flash", it puts a <use> in the main layer (that's a lot of uses). Then, when we start combining gerber-to-svg layers together with pcb-stackup, we end up with a bunch of nested <use>s, because the layers get put into defs and then <use>d themselves.

I'd like to compare a build that just inserts the shapes directly into the main to the current version to see if things feel faster (especially with some of the more complicated boards in the pcb-stackup integration tests).

@mcous
Copy link
Member Author

mcous commented Jul 22, 2018

Now tracking in tracespace/tracespace#80

@mcous mcous closed this as completed Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant