Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping country codes to verbose names #8

Open
willowo opened this issue Oct 15, 2014 · 3 comments
Open

Mapping country codes to verbose names #8

willowo opened this issue Oct 15, 2014 · 3 comments

Comments

@willowo
Copy link
Member

willowo commented Oct 15, 2014

Currently TradeMapper only displays the two-letter ISO country code as found in the .csv file. However, it would be much more user friendly if this mapped to full country names e.g. DE -> Germany, CH -> Switzerland.

@foobacca
Copy link
Contributor

foobacca commented Nov 3, 2014

The data is in the map data, so we can easily get that.

However some elements might need a redesign for the longer text (eg the hover box)

@neilgunn neilgunn added this to the hackday November 2014 milestone Nov 7, 2014
@foobacca
Copy link
Contributor

Resolved by pull #29 and #32 - we have full names in the filter dropdowns, and in the hover boxes we still use the country codes (to avoid having to accomodate longer text in the restricted space, but if you hover over the country codes it shows you the country name. We might want to review that.

@willowo
Copy link
Member Author

willowo commented Nov 13, 2014

Some country codes (e.g. BB, AN, BH) are displaying the 2 letter code rather than the full name in the drop down, what's the reason for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants