Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hit box from the text of marker is incorrectly shifted to the right #1305

Conversation

victorbrambati
Copy link
Contributor

@victorbrambati victorbrambati commented Mar 17, 2023

Type of PR: bugfix

PR checklist:

Overview of change:

  • The function hitTestText() was using the Coordinate x from the item and not from own coordinate. So I created the item.text.x and put it in hitTestText().

Glitch Code Sandbox link:
https://glitch.com/edit/#!/bold-noble-pheasant

@victorbrambati
Copy link
Contributor Author

I need help to create the tests.

@SlicedSilver
Copy link
Contributor

Thank you @victorbrambati, I'll try review this today and add a test.
Was planning on creating a new version of the library today (v4.0.1) but might be worth waiting a bit longer so this can be included in that patch as well.

@victorbrambati
Copy link
Contributor Author

@SlicedSilver Interesting! Thank you for the support.

@SlicedSilver SlicedSilver self-requested a review March 20, 2023 10:20
@SlicedSilver SlicedSilver merged commit 16271d1 into tradingview:master Mar 21, 2023
@SlicedSilver SlicedSilver modified the milestones: 4.1, 4.0.1 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hoveredMarkerId for marker text within subscribeClick event
2 participants