Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightweight-charts not working on Android browser #156

Closed
yuyic opened this issue Aug 4, 2019 · 10 comments
Closed

Lightweight-charts not working on Android browser #156

yuyic opened this issue Aug 4, 2019 · 10 comments

Comments

@yuyic
Copy link

yuyic commented Aug 4, 2019

Android version: 5.0 and 6.0.1
Lightweight-charts demo can not be rendered on Android browser, but Chartinglibrary of TradingView work correctlly, it is a serious problem. Does anyone have solutions?

@timocov
Copy link
Contributor

timocov commented Aug 5, 2019

I think the reason is in polyfills, see #101 (comment).

@yuyic
Copy link
Author

yuyic commented Aug 5, 2019

I've imported pollyfill, it's not polyfill reason, the problem is canvas rendering a weird black and white content, I tried in two devices, Android5 and 6.0.1, both have the same issue.

@timocov
Copy link
Contributor

timocov commented Aug 5, 2019

Do you have any errors on the page? Can you please share screenshots what's going wrong?

@yuyic
Copy link
Author

yuyic commented Aug 5, 2019

There are no errors on the page, here are some screenshots in Android 6.0.1 native browser.
20190805173752
20190805173831
20190805173851
20190805173916

@SuperPenguin
Copy link
Contributor

SuperPenguin commented Aug 5, 2019

I tried on my old phone and it worked fine. Mi 4i with android 5.0.2, but I use latest chrome browser from play store.

Screenshot_2019-08-05-18-55-01-164_com android settings
Screenshot_2019-08-05-18-54-38-437_com android chrome

@yuyic
Copy link
Author

yuyic commented Aug 5, 2019

I tried on my old phone and it worked fine. Mi 4i with android 5.0.2, but I use latest chrome browser from play store.

Hi, you should try in Android Native Browser, it not works!
I want use the chart in React-Native, so I need native browser support.
Any solutions?

@timocov
Copy link
Contributor

timocov commented Aug 5, 2019

We'll investigate it and will back here with updates.

@timocov
Copy link
Contributor

timocov commented Aug 5, 2019

@yuyic can you please check it on https://github.com/tradingview/lightweight-charts/tree/141-fancy-canvas branch?

@timocov
Copy link
Contributor

timocov commented Aug 5, 2019

It looks like Android browser doesn't like undefined as the first argument in fill method (we have a lot of errors about it - are you sure that you haven't any JS error?).

@yuyic
Copy link
Author

yuyic commented Aug 6, 2019

Thanks for your quick response, it works now!
Sorry I didn't do a complete debug, it's my fault, I just saw the errors...

@yuyic yuyic closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants