Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing docs for generating screenshots #193

Closed
timocov opened this issue Sep 5, 2019 · 2 comments · Fixed by #256
Closed

Missing docs for generating screenshots #193

timocov opened this issue Sep 5, 2019 · 2 comments · Fixed by #256
Assignees
Labels
documentation Improvements or additions to the documentation
Milestone

Comments

@timocov
Copy link
Contributor

timocov commented Sep 5, 2019

Originally posted by @hazhir1811 in #48 (comment)

@timocov timocov added the documentation Improvements or additions to the documentation label Sep 5, 2019
@timocov timocov added this to the 1.2.0 milestone Sep 5, 2019
@0x48415a484952
Copy link

looks like when taking screenshots the legends are not part of screen shot. also if we take the screenshot immediately after the page has loaded the markers above or below the candles would be a little bit above the candles that normally would be you can see this part when you refresh a series of candles that has some markers above the candles with a very short delay the markers get adjusted to the candles.

@timocov
Copy link
Contributor Author

timocov commented Oct 18, 2019

looks like when taking screenshots the legends are not part of screen shot

@hazhir1811 The lightweight-charts doesn't have legend out of the box. What legend are you talking about?

also if we take the screenshot immediately after the page has loaded the markers above or below the candles would be a little bit above the candles that normally would be you can see this part when you refresh a series of candles that has some markers above the candles with a very short delay the markers get adjusted to the candles.

I hope that this issue is #212 or has really similar reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants