Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double clicking on time scale will reset fix left edge #224

Closed
deantheiceman opened this issue Sep 30, 2019 · 4 comments · Fixed by #259
Closed

Double clicking on time scale will reset fix left edge #224

deantheiceman opened this issue Sep 30, 2019 · 4 comments · Fixed by #259
Assignees
Labels
bug Unexpected problem or unintended behavior.
Milestone

Comments

@deantheiceman
Copy link

Lightweight Charts Version:

Steps/code to reproduce:

When using fix left edge, if I double click on the "time scale" even with disabling scroll and scale it will reset the zoom level

  priceScale: {
    position: 'right',
    borderVisible: false,
    scaleMargins: {
      top: 0.2,
      bottom: 0.125
    }
  },
  timeScale: {
    borderVisible: false,
    fixLeftEdge: true,
    lockVisibleTimeRangeOnResize: true,
    rightBarStaysOnScroll: true,
    secondsVisible: false
  },
  layout: {
    backgroundColor: '#ffffff',
    textColor: '#333'
  },
  grid: {
    horzLines: {
      color: '#eee'
    },
    vertLines: {
      color: '#ffffff'
    }
  },
  crosshair: {
    vertLine: {
      labelVisible: true
    }
  },
  handleScroll: {
    mouseWheel: false,
    pressedMouseMove: false
  },
  handleScale: {
    axisPressedMouseMove: false,
    mouseWheel: false,
    pinch: false
  },

Expected, it should not change the time scale

@deantheiceman
Copy link
Author

Is there also a way to fix the time scale from showing random data points?
image

How can we set it to show intervals of 30 minutes etc instead of the random points

@eugene-korobko
Copy link
Contributor

Hello!

I can approve bug with double-click, it will be fixed in the nearest releases

@deantheiceman
Copy link
Author

@eugene-korobko thanks!

Do you have any ideas about how to format the time?

@eugene-korobko eugene-korobko added this to the 1.2.0 milestone Oct 1, 2019
@timocov timocov added bug Unexpected problem or unintended behavior. good first issue Good issue for first-time contributors. labels Oct 16, 2019
@timocov
Copy link
Contributor

timocov commented Oct 16, 2019

Hey @deantheiceman,

currently we trying to show uniformly time scale (and grid as well) so I hope it depends on the data you provided. Quite possible that in case of generating time scale marks by just some time (e.g. by 30 minutes) it could be look strange and uniform.

@eugene-korobko eugene-korobko self-assigned this Nov 19, 2019
@timocov timocov removed the good first issue Good issue for first-time contributors. label Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants