Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram has some space below bars when markers are added #1382

Closed
plagun98 opened this issue Jun 21, 2023 · 2 comments · Fixed by #1538
Closed

Histogram has some space below bars when markers are added #1382

plagun98 opened this issue Jun 21, 2023 · 2 comments · Fixed by #1538
Labels
bug Unexpected problem or unintended behavior. help wanted Asking for outside help and/or contributions to this particular issue or PR.
Milestone

Comments

@plagun98
Copy link

plagun98 commented Jun 21, 2023

Lightweight Charts™ Version: 4.0.1

Steps/code to reproduce:

Add histogram to the chart, set priceScaleId: '', add markers to the histogram series

Actual behavior:

Some space appears below the histogram

Expected behavior:

No space between histogram and bottom of the chart

Screenshots:

image

CodeSandbox/JSFiddle/etc link:
https://jsfiddle.net/exuqzLh5/

@SlicedSilver
Copy link
Contributor

Thanks @plagun98.
Having a look at your provided code sample I can't see anything that you've done incorrectly, and I can see the same behaviour as you show in the screenshot.

We would need to investigate further but I would assume that we are leaving space under the series because there might be a marker that we could want to drawn in that space. So the library might need a ignoreMarkersDuringAutoScaling option added to the PriceScaleOptions.

I'll mark this as a bug for now.

@SlicedSilver SlicedSilver added bug Unexpected problem or unintended behavior. help wanted Asking for outside help and/or contributions to this particular issue or PR. labels Jun 21, 2023
@winfirm
Copy link

winfirm commented Jul 4, 2023

I met the same case, when I applied MACD histogram to candle chart in a single chart object, there came some gaps in both histogram and candle area.

@SlicedSilver SlicedSilver added this to the 4.1.x milestone Oct 12, 2023
@illetid illetid mentioned this issue Mar 8, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior. help wanted Asking for outside help and/or contributions to this particular issue or PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants