Improved organization and removed redundancy #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved all args to a json file. Argchecker now uses assert
added png files to ignore
formatting args correctly
passed the args dictionary to remove redundancy.
and removed a bug where 1 day of data was lost
|
This is fantastic. Just one question before I merge this, did you test it a few times? Thanks a lot for the PR. |
|
Yes I did test the code. It did not have any discrepancies. You can pull the PR and and double test for peace of mind xD |
Migrated operations to vectorized mode now we use ndarrays & pandas instead of lists (improves speed so we can use more stocks)
This reverts commit 72c609a.
|
Thank you for putting your time into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tackles the redundancies that were created by separating each argument.
Now the args dictionary is passed and any new argument added or change is automatically passed.
Also separated files so users can import Eiten and use it as a library,