Added Support for Crypto-Currencies list on Binance #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support Crypto-Currencies listed on Binance. With some simple modifications you can add support for more data sources/exchanges with ease.
List of changes:
- Added argument checking. Data source must be either 'yahoo_finance' or 'binance', stocks list must exist in the stocks folder
- Added new two input parameters to data_loader.py,
- changed how the stocks list is read by using the file indicated by the stocks_list parameter
- added the ability to get data from the binance client
- line 188-190 fixed bug with saving dictionary every 100 iterations. Due to the continue statements, the size of the dictionary can increase but checking if you need to save the file may not occur. Thus, I moved the statement which checks if we need to save the dictionary immediately after we add to the dictionary