Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting dashboard entryPoints for ingressRoute resource #640

Merged
merged 3 commits into from Oct 3, 2022

Conversation

abarrak
Copy link
Contributor

@abarrak abarrak commented Oct 1, 2022

What does this PR do?

This allows overriding entryPoints when the dashboard is to be exposed over web , or websecure.

Motivation

In certain cases, people need to expose the dashboard through web 80 or websecure 443.
It's not feasible through values.yaml as it not available, thus requires applying it manually as specified in README.

This makes it difficult to manage when used as dependency.
For example k3s auto-updating HelmChart CRD would override the configured values back to the fixed defaulttraefik.
See this.

More

  • Yes, I updated the chart version

  • Added unit tests, and all test suite is passing:

Tests output
== Cleaning...
== Cleaning Finished
== Checking global requirements...
== Checking requirements for linting...
== Requirements for linting are met.
== Linting Chart...
Linting charts...
>>> helm version --template {{ .Version }}
>>> git rev-parse --is-inside-work-tree
>>> git merge-base traefik/master HEAD
>>> git diff --find-renames --name-only 803a973ef9c1055a0a6e889623c8d2451733f362 -- ./

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 traefik => (version: "10.30.2", path: "traefik")
------------------------------------------------------------------------------------------------------------------------

>>> helm dependency build traefik
Linting chart "traefik => (version: \"10.30.2\", path: \"traefik\")"
Checking chart "traefik => (version: \"10.30.2\", path: \"traefik\")" for a version bump...
>>> git cat-file -e traefik/master:traefik/Chart.yaml
>>> git show traefik/master:traefik/Chart.yaml
Old chart version: 10.30.1
New chart version: 10.30.2
Chart version ok.
>>> yamale --schema chart_schema.yaml traefik/Chart.yaml
Validating ~/lab/traefik-helm-chart/traefik/Chart.yaml...
Validation success! 馃憤
>>> yamllint --config-file lintconf.yaml traefik/Chart.yaml
>>> yamllint --config-file lintconf.yaml traefik/values.yaml
Validating maintainers...
>>> git ls-remote --get-url traefik
>>> helm lint traefik
==> Linting traefik

1 chart(s) linted, 0 chart(s) failed
------------------------------------------------------------------------------------------------------------------------
 鉁旓笌 traefik => (version: "10.30.2", path: "traefik")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully
== Linting Finished
== Checking that plugin helm-unittest is available...
== plugin helm-unittest is ready
== Unit Testing Chart...

### Chart [ traefik ] ./traefik

 PASS  Main Container configuration	traefik/tests/container-config_test.yaml
 PASS  DaemonSet configuration	traefik/tests/daemonset-config_test.yaml
 PASS  Dashboard IngressRoute configuration	traefik/tests/dashboard-hook-ingressroute_test.yaml
 PASS  default install	traefik/tests/default-install_test.yaml
 PASS  Deployment configuration	traefik/tests/deployment-config_test.yaml
 PASS  Gateway configuration	traefik/tests/gateway-config_test.yaml
 PASS  GatewayClass configuration	traefik/tests/gatewayclass-config_test.yaml
 PASS  Pod configuration	traefik/tests/pod-config_test.yaml
 PASS  PodDisruptionBudget configuration	traefik/tests/poddisruptionbudget-config_test.yaml
 PASS  PodSecurityPolicy configuration	traefik/tests/podsecuritypolicy-config_test.yaml
 PASS  Traefik configuration	traefik/tests/ports-config_test.yaml
 PASS  RBAC configuration	traefik/tests/rbac-config_test.yaml
 PASS  Service configuration	traefik/tests/service-config_test.yaml
 PASS  Traefik configuration	traefik/tests/traefik-config_test.yaml

Charts:      1 passed, 1 total
Test Suites: 14 passed, 14 total
Tests:       127 passed, 127 total
Snapshot:    0 passed, 0 total
Time:        752.954952ms

== Unit Tests Finished...
== Building Chart...
Successfully packaged chart and saved it to: ~/lab/traefik-helm-chart/dist/traefik-10.30.2.tgz
...

Additional Notes

Thank you!

traefik/Chart.yaml Outdated Show resolved Hide resolved
traefik/values.yaml Outdated Show resolved Hide resolved
@mloiseleur mloiseleur self-assigned this Oct 3, 2022
@mloiseleur mloiseleur added the kind/enhancement New feature or request label Oct 3, 2022
@mloiseleur
Copy link
Contributor

Hello @abarrak,

Thanks for your PR and your interest in Traefik !

I left a few suggestion onto your PR. We can merge it, after.

@abarrak
Copy link
Contributor Author

abarrak commented Oct 3, 2022

Thanks @mloiseleur,
All review comments applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants