Bump go 1.8 #1259
Merged
Bump go 1.8 #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
force-pushed
the
bump-go-1.8
branch
3 times, most recently
from
7021f43
to
b344f93
Compare
timoreimann
reviewed
Mar 8, 2017
server.go
Outdated
| log.Infof("Starting server on %s", srv.Addr) | ||
| if srv.TLSConfig != nil { | ||
| if err := srv.ListenAndServeTLSWithConfig(srv.TLSConfig); err != nil { | ||
| err := srv.ListenAndServeTLS("", "") |
There was a problem hiding this comment.
You could declare the err variable at the top, assign it in each TLS/no-TLS case, and check for nil once only:
var err error
if srv.TLSConfig != nil {
err = srv.ListenAndServeTLS("", "")
} else {
err = srv.ListenAndServe()
}
if err != nil {
log.Fatal("Error creating server: ", err)
}Saves us one nested level of ifing.
server.go
Outdated
| cancel() | ||
| }() | ||
| <-ctx.Done() | ||
| log.Debugf("Waiting %d seconds before killing connections on entrypoint %s...", server.globalConfiguration.GraceTimeOut, serverEntryPointName) |
There was a problem hiding this comment.
What's the reason we don't wrap this in a go routine anymore?
IIUC, we are now shutting down the server entry points sequentially whereas we used to do so concurrently.
There was a problem hiding this comment.
In fact, it was not working in the old version because of <-ctx.Done().
I used a WaitGroup instead.
emilevauge
force-pushed
the
bump-go-1.8
branch
2 times, most recently
from
cac3b97
to
101f6aa
Compare
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
timoreimann
force-pushed
the
bump-go-1.8
branch
from
d0e741e
to
1140ee6
Compare
|
Updated and green! We need one more LGTM. :-) |
ldez
added
status/3-needs-merge
and removed
status/2-needs-review
status/1-needs-design-review
labels
ldez
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps go version to 1.8 and removes dependency to https://github.com/mailgun/manners using native graceful shutdown instead.