Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in code comment. #1473

Merged
merged 1 commit into from Apr 20, 2017
Merged

Conversation

mattcollier
Copy link
Contributor

No description provided.

@@ -15,7 +15,7 @@ import (
var singleton *HealthCheck
var once sync.Once

// GetHealthCheck Get HealtchCheck Singleton
// GetHealthCheck Get HealthCheck Singleton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a proper GoDoc string and say something like

// GetHealthCheck returns the health check which is guaranteed to be a singleton.

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. :-)

Could you squash your commits please?

@mattcollier
Copy link
Contributor Author

@timoreimann Sure, done.

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

@timoreimann timoreimann merged commit 809103f into traefik:master Apr 20, 2017
@ldez ldez modified the milestone: 1.3 Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants