Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added constraint management for Rancher provider #1527

Merged
merged 1 commit into from May 3, 2017
Merged

Added constraint management for Rancher provider #1527

merged 1 commit into from May 3, 2017

Conversation

yyekhlef
Copy link
Contributor

@yyekhlef yyekhlef commented May 2, 2017

Added constraint management for the Rancher provider. This enables filtering capabilities like described in the documentation https://docs.traefik.io/toml/#constraints

@ldez ldez added kind/enhancement a new or improved feature. area/provider/rancher labels May 2, 2017
@ldez ldez requested a review from SantoDE May 2, 2017 15:13
ldez
ldez requested changes May 2, 2017
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool! 🎉 🍺
Could you update docs/toml.md ?

@yyekhlef
Copy link
Contributor Author

yyekhlef commented May 2, 2017

Thx ! My first PR ! :-)
I've already updated docs/toml.md. Just pointed out that Rancher provider now supports constraints. You need more details ?

@yyekhlef
Copy link
Contributor Author

yyekhlef commented May 2, 2017

@ldez : it was probably my eyes... i'm updating the Rancher part. :-)

@ldez
Copy link
Member

ldez commented May 2, 2017 •
edited

I'm speaking about: https://github.com/containous/traefik/blob/master/docs/toml.md#rancher-backend

ldez
ldez approved these changes May 2, 2017
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancel... Mistake, everything is ok!

@emilevauge
Copy link
Member

Hey @yyekhlef, welcome on board ❤️ !
Could you squash your commits and push force to your branch instead of using a revert commit ?
Thanks a lot :)
Love your PR 👍

@yyekhlef
Copy link
Contributor Author

yyekhlef commented May 2, 2017

Hello @emilevauge thanks. :-)

Squash done.

@ldez ldez modified the milestone: 1.3 May 3, 2017
SantoDE
SantoDE approved these changes May 3, 2017
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yyekhlef

thanks a lot! Your PR is <3.

LGTM 👼

@yyekhlef
Copy link
Contributor Author

yyekhlef commented May 3, 2017

Thx @SantoDE

@SantoDE
Copy link
Collaborator

SantoDE commented May 3, 2017

Haha @yyekhlef. I was actually just about to rebase your PR :) Can you now squash the merge again please again? Once tests are green, I'll merge

@yyekhlef
Copy link
Contributor Author

yyekhlef commented May 3, 2017

Sorry @SantoDE I do it now. :-)

@ldez ldez closed this May 3, 2017
@ldez ldez reopened this May 3, 2017
@ldez ldez merged commit b67a27d into traefik:master May 3, 2017
@ldez ldez changed the title feat(rancher): added constraint management for rancher provider Added constraint management for rancher provider May 26, 2017
@ldez ldez changed the title Added constraint management for rancher provider Added constraint management for Rancher provider May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/provider/rancher kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yyekhlef @ldez @emilevauge @SantoDE