Remove rule type path list. #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emilevauge and others: I think this one should still go into 1.3. If you believe that master is the better target, please let me know and I'll rebase. |
emilevauge
requested changes
May 19, 2017
There was a problem hiding this comment.
@timoreimann great move ;)
Could you add some tests on PathPrefixStrip PathStrip & Path rules?
This is linked to the previous PR #1151.
|
@emilevauge Pushed more tests. Not sure if that's what you had in mind though since the new implementation doesn't care what value we put into the annotation (the validation now happens in Let me know. :-) |
timoreimann
force-pushed
the
kubernetes-remove-path-rules
branch
from
1a94d6f
to
2d74241
Compare
Instead of doing sanity checks in the Kubernetes provider, we just accept any non-empty value from the annotation and rely on the server part to filter out unknown rules. This allows us to automatically stay in sync with the currently supported Path matchers/modifiers.
ldez
force-pushed
the
kubernetes-remove-path-rules
branch
from
2d74241
to
1757671
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing sanity checks in the Kubernetes provider, we just accept any non-empty value from the annotation and rely on the server part to filter out unknown rules.
This allows us to automatically stay in sync with the currently supported Path matchers/modifiers.
Fixes #1627.