Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

healthcheck should not require deprecated web provider #2524

Closed
wenzowski opened this issue Dec 4, 2017 · 3 comments
Closed

healthcheck should not require deprecated web provider #2524

wenzowski opened this issue Dec 4, 2017 · 3 comments

Comments

@wenzowski
Copy link

Now that the web provider has been deprecated, the healthcheck command should probably get its config from api instead of depending on web as documented.

It's currently calling globalConfiguration.Web.Path.

What did you do?

HEALTHCHECK  CMD ["/traefik", "healthcheck", "--web"]

What did you expect to see?

OK: http://:8080/ping

What did you see instead?

web provider configuration is deprecated, you should use these options : api, rest provider, ping and metrics
OK: http://:8080/ping

Output of traefik version: (What version of Traefik are you using?)

Version:      v1.5.0-rc1
Codename:     cancoillotte
Go version:   go1.9.2
Built:        2017-11-28_02:11:24PM
OS/Arch:      linux/amd64

What is your environment & configuration (arguments, toml, provider, platform, ...)?

{
 "LifeCycle": null,
 "GraceTimeOut": 0,
 "Debug": false,
 "CheckNewVersion": true,
 "SendAnonymousUsage": false,
 "AccessLogsFile": "",
 "AccessLog": null,
 "TraefikLogsFile": "",
 "TraefikLog": null,
 "LogLevel": "ERROR",
 "EntryPoints": {},
 "Cluster": null,
 "Constraints": [],
 "ACME": null,
 "DefaultEntryPoints": [],
 "ProvidersThrottleDuration": 2000000000,
 "MaxIdleConnsPerHost": 200,
 "IdleTimeout": 0,
 "InsecureSkipVerify": false,
 "RootCAs": null,
 "Retry": null,
 "HealthCheck": {
  "Interval": 30000000000
 },
 "RespondingTimeouts": null,
 "ForwardingTimeouts": null,
 "Web": null,
 "Docker": null,
 "File": null,
 "Marathon": null,
 "Consul": null,
 "ConsulCatalog": null,
 "Etcd": null,
 "Zookeeper": null,
 "Boltdb": null,
 "Kubernetes": null,
 "Mesos": null,
 "Eureka": null,
 "ECS": null,
 "Rancher": null,
 "DynamoDB": null,
 "ServiceFabric": null,
 "Rest": null,
 "API": null,
 "Metrics": null,
 "Ping": null,
 "ConfigFile": ""
}

Sample Dockerfile using HEALTHCHECK

@ldez
Copy link
Member

ldez commented Dec 5, 2017

@wenzowski If you use 1.5 please refer to this documentation: http://v1-5.archive.docs.traefik.io/

http://v1-5.archive.docs.traefik.io/configuration/ping/

@wenzowski
Copy link
Author

Thanks for the link correction @ldez
Web is still required in docs there too http://v1-5.archive.docs.traefik.io/basics/#command-healthcheck

The point of this issue is that if --web or [web] in toml is not provided, then the healthcheck fails due to a null reference of globalConfiguration.Web.Path. But [web] is deprecated.

@traefiker
Copy link
Contributor

Closed by #2529.

@traefiker traefiker added this to the 1.5 milestone Dec 6, 2017
@mmatur mmatur added kind/bug/confirmed a confirmed bug (reproducible). and removed status/0-needs-triage labels Dec 6, 2017
@traefik traefik locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants