Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadConfig modifies configuration causing same config check to fail #480

Closed
keis opened this issue Jun 23, 2016 · 3 comments
Closed

loadConfig modifies configuration causing same config check to fail #480

keis opened this issue Jun 23, 2016 · 3 comments
Labels
Milestone

Comments

@keis
Copy link

keis commented Jun 23, 2016

Moving my comment from #478 to make it easier to track.

In same config check the "old" config also have loadBalancer blocks in the backend config where the new from the provider does not. This from line 444 in server.go

I think the fix to this is to never modify the config in loadConfig but I'm not really sure where should go instead.

        "backend-eremetic": {
            "servers": {
                "eremetic--10-4-72-161--8182--monitor--api--monitor--6": {
                    "url": "http://10.4.72.161:8182",
                    "weight": 0
                }
            },
            "loadBalancer": {
                "method": "wrr"
            }
        },
        "backend-eremetic": {
            "servers": {
                "eremetic--10-4-72-161--8182--monitor--api--monitor--6": {
                    "url": "http://10.4.72.161:8182",
                    "weight": 0
                }
            }
        },
@keis keis changed the title loadConfig modifies configuration causing same config check to always fail loadConfig modifies configuration causing same config check to fail Jun 23, 2016
@emilevauge
Copy link
Member

@keis Nice catch! I will fix this for the 1.0.

@emilevauge
Copy link
Member

@keis you can test it using containous/traefik:pr-491 ;)

@keis
Copy link
Author

keis commented Jul 12, 2016

Tried the current master and it all works great now. I see the messages about defaulting the load balancer method followed by "Skipping same configuration for provider consul_catalog". 👍

@ldez ldez added the kind/bug/confirmed a confirmed bug (reproducible). label Apr 29, 2017
@traefik traefik locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants