You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When building traefik from the master branch recently, I noticed that when I execute the traefik version command, the data displayed are the default hard coded values:
Version: dev
Codename: cheddar
Go version: go1.6.3
Built: I don't remember exactly
OS/Arch: linux/amd64
I believe the problem is related to this changeset moving the version-related variables out of the main package.
To fix, I think this line needs changed so that the variables that are being replaced contain the fully qualified package name, like this:
CGO_ENABLED=0 GOGC=off go build $FLAGS -ldflags "-s -w -X github.com/containous/traefik/version.Version=$VERSION -X github.com/containous/traefik/version.Codename=$CODENAME -X github.com/containous/traefik/version.BuildDate=$DATE" -a -installsuffix nocgo -o dist/traefik .
When I make that change locally, the version command seems to print the right stuff:
I don't know Go all that well. I'd be willing to submit a pull request but I'm hoping someone from this project will comment whether this seems like the right fix. I also wouldn't mind if someone just fixed it. :)
The text was updated successfully, but these errors were encountered:
When building traefik from the master branch recently, I noticed that when I execute the
traefik version
command, the data displayed are the default hard coded values:I believe the problem is related to this changeset moving the version-related variables out of the main package.
To fix, I think this line needs changed so that the variables that are being replaced contain the fully qualified package name, like this:
When I make that change locally, the version command seems to print the right stuff:
I don't know Go all that well. I'd be willing to submit a pull request but I'm hoping someone from this project will comment whether this seems like the right fix. I also wouldn't mind if someone just fixed it. :)
The text was updated successfully, but these errors were encountered: