Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotation documentation for middleware incorrect #6506

Closed
travisghansen opened this issue Mar 17, 2020 · 4 comments · Fixed by #6504
Closed

annotation documentation for middleware incorrect #6506

travisghansen opened this issue Mar 17, 2020 · 4 comments · Fixed by #6504

Comments

@travisghansen
Copy link

Do you want to request a feature or report a bug?

Bug

What did you do?

Try adding a middleware to an Ingress per the doc of the new feature in 2.2.

https://github.com/containous/traefik/pull/6160/files

traefik.ingress.kubernetes.io/router.middlewares: prefix@kuberntes-crd

What did you expect to see?

The middleware applied to the Ingress

What did you see instead?

Failure and a 404 on the endpoint.

Output of traefik version: (What version of Traefik are you using?)

2.2.0-rc2

What is your environment & configuration (arguments, toml, provider, platform, ...)?

Ingress mode installed via the helm chart.

Simply removing the - from the namespace aspect of the middleware works.

ie: traefik.ingress.kubernetes.io/router.middlewares: prefix@kuberntescrd

Also, it may be good to give some explanation about the autogenerated names of the middlewares created via CRD. For example explain something like:

Middlewares created via CRD take the format of `<k8s namespace>-<k8s name>@kubernetescrd`.
@ldez
Copy link
Member

ldez commented Mar 17, 2020

Hello,

could you open a PR on the branch v2.2 to fix that?

Thanks.

@ldez ldez added this to issues in v2 via automation Mar 17, 2020
@travisghansen
Copy link
Author

I'm pretty strapped for time currently. Mostly just letting you know. If I get a chance I'll see what I can do though.

@ldez
Copy link
Member

ldez commented Mar 17, 2020

Fixed in d5cbb6028ff72f197b74f8f6e47f7c069058426c

@ldez ldez mentioned this issue Mar 17, 2020
2 tasks
@traefiker traefiker added this to the 2.2 milestone Mar 18, 2020
@dtomcej dtomcej linked a pull request Mar 18, 2020 that will close this issue
2 tasks
v2 automation moved this from issues to Done Mar 18, 2020
@traefiker
Copy link
Contributor

Closed by #6504.

@traefik traefik locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
v2
Done
Development

Successfully merging a pull request may close this issue.

3 participants