Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Marathon events that fail health checks or are not running #81

Closed
stevendborrelli opened this issue Oct 29, 2015 · 5 comments
Closed
Assignees
Milestone

Comments

@stevendborrelli
Copy link

We've seen some 503 issues in our deployment and think it is related to the way marathon describes tasks.

For example, in https://mesosphere.github.io/marathon/docs/rest-api.html#get-v2-tasks, we can filter tasks that are staged but not running

We should also have the ability to filter tasks that fail a health check.

@emilevauge emilevauge added the kind/enhancement a new or improved feature. label Oct 29, 2015
@emilevauge emilevauge self-assigned this Oct 29, 2015
@emilevauge emilevauge added the bug label Oct 29, 2015
@emilevauge
Copy link
Member

Hi @stevendborrelli, thanks for reporting :)
You are absolutely right, we need to filter staging tasks from being routed.
I think that if a task is in running status, that means that its health check is ok.
Therefore, it should be OK to only filter on status.
OK for you?

@emilevauge emilevauge removed the kind/enhancement a new or improved feature. label Oct 29, 2015
@stevendborrelli
Copy link
Author

Sounds good! We have a cluster here we can test on.

@emilevauge
Copy link
Member

Well, the go API doesn't allow to filter tasks by status, I will use healthcheck result instead...
https://github.com/gambol99/go-marathon/blob/master/task.go
But that's not completely satisfying, healthchecks are not mandatory.

@emilevauge
Copy link
Member

Created an issue gambol99/go-marathon#81 on that point ;)

@emilevauge
Copy link
Member

A PR has been made on go-marathon: gambol99/go-marathon#82. I will use this feature in traefik to get only running tasks.

@ghost ghost mentioned this issue Nov 4, 2015
@emilevauge emilevauge modified the milestone: 1.0 Feb 27, 2016
@traefik traefik locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants