-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL Variables as Docker Labels? #98
Comments
Looked into it a little more when trying to pass that as a Docker label the toml package throws the following error:
Looks like because the entire frontend name is being used as per docker.tmpl it's attempting also inject the regex into the table name. Please see the referenced commit for my fixes. If you think these are inline I can make a PR. I'm not exactly sure what to return with if the parsing failed. Right now it returns the original string (Don't like this) |
Hi @polds, thank you for reporting. This is an issue. We have to find a smart way to do that. I'm not sure to understand what does: "makeParsedUrl": func(s1 string) string {
if u, err := url.Parse(s1); err == nil {
return u.String()
}
return s1
}, Could you explain a little bit ? |
@emilevauge it converts the string to their html entities counterparts. Going in the string is My biggest concern is if the Edit: The TOML parser was only specifically complaining about the
|
@polds, OK I get it. I definitely prefer the second solution to reuse the |
Or even better, should be added directly here: https://github.com/emilevauge/traefik/blob/master/provider/docker.go#L209 |
Wondering if it's possible to do URL Variables as part of a Docker label like so:
The text was updated successfully, but these errors were encountered: