New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KeepAliveMaxTime and KeepAliveMaxRequests features to entrypoints #10247
Conversation
b391d98
to
41b3e13
Compare
there are some unrelated changes, I think it's because you are using the latest version of golangci-lint. Edit: the PR #10248 |
aef24d3
to
17b79cb
Compare
0d771c6
to
d1d97be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Co-authored-by: Kevin Pollet <pollet.kevin@gmail.com>
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [traefik](https://github.com/containous/traefik) | minor | `2.10` -> `v2.11` | --- > ⚠ **Warning** > > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>containous/traefik (traefik)</summary> ### [`v2.11`](https://github.com/containous/traefik/blob/HEAD/CHANGELOG.md#v2110-rc1-2024-01-02) [All Commits](traefik/traefik@0a79643...v2.11.0-rc1) **Enhancements:** - **\[middleware]** Deprecate IPWhiteList middleware in favor of IPAllowList ([#​10249](traefik/traefik#10249) by [lbenguigui](https://github.com/lbenguigui)) - **\[redis]** Add Redis Sentinel support ([#​10245](traefik/traefik#10245) by [youkoulayley](https://github.com/youkoulayley)) - **\[server]** Add KeepAliveMaxTime and KeepAliveMaxRequests features to entrypoints ([#​10247](traefik/traefik#10247) by [juliens](https://github.com/juliens)) - **\[sticky-session]** Hash WRR sticky cookies ([#​10243](traefik/traefik#10243) by [youkoulayley](https://github.com/youkoulayley)) **Bug fixes:** - **\[file]** Update github.com/fsnotify/fsnotify to v1.7.0 ([#​10313](traefik/traefik#10313) by [ldez](https://github.com/ldez)) - **\[http3]** Update quic-go to v0.40.1 ([#​10296](traefik/traefik#10296) by [ldez](https://github.com/ldez)) - **\[server]** Fix ReadHeaderTimeout for PROXY protocol ([#​10320](traefik/traefik#10320) by [juliens](https://github.com/juliens)) **Documentation:** - **\[acme]** Fix TLS challenge explanation ([#​10293](traefik/traefik#10293) by [cavokz](https://github.com/cavokz)) - **\[docker,acme]** Fix typo ([#​10294](traefik/traefik#10294) by [youpsla](https://github.com/youpsla)) - **\[docker]** Update wording of compose example ([#​10276](traefik/traefik#10276) by [svx](https://github.com/svx)) - **\[k8s/crd]** Adjust deprecation notice for Kubernetes CRD provider ([#​10317](traefik/traefik#10317) by [rtribotte](https://github.com/rtribotte)) - Fix description for anonymous usage statistics references ([#​10287](traefik/traefik#10287) by [ariyonaty](https://github.com/ariyonaty)) - Documentation enhancements ([#​10261](traefik/traefik#10261) by [svx](https://github.com/svx)) ### [`v2.11`](https://github.com/containous/traefik/blob/HEAD/CHANGELOG.md#v2110-rc1-2024-01-02) [All Commits](traefik/traefik@0a79643...v2.11.0-rc1) **Enhancements:** - **\[middleware]** Deprecate IPWhiteList middleware in favor of IPAllowList ([#​10249](traefik/traefik#10249) by [lbenguigui](https://github.com/lbenguigui)) - **\[redis]** Add Redis Sentinel support ([#​10245](traefik/traefik#10245) by [youkoulayley](https://github.com/youkoulayley)) - **\[server]** Add KeepAliveMaxTime and KeepAliveMaxRequests features to entrypoints ([#​10247](traefik/traefik#10247) by [juliens](https://github.com/juliens)) - **\[sticky-session]** Hash WRR sticky cookies ([#​10243](traefik/traefik#10243) by [youkoulayley](https://github.com/youkoulayley)) **Bug fixes:** - **\[file]** Update github.com/fsnotify/fsnotify to v1.7.0 ([#​10313](traefik/traefik#10313) by [ldez](https://github.com/ldez)) - **\[http3]** Update quic-go to v0.40.1 ([#​10296](traefik/traefik#10296) by [ldez](https://github.com/ldez)) - **\[server]** Fix ReadHeaderTimeout for PROXY protocol ([#​10320](traefik/traefik#10320) by [juliens](https://github.com/juliens)) **Documentation:** - **\[acme]** Fix TLS challenge explanation ([#​10293](traefik/traefik#10293) by [cavokz](https://github.com/cavokz)) - **\[docker,acme]** Fix typo ([#​10294](traefik/traefik#10294) by [youpsla](https://github.com/youpsla)) - **\[docker]** Update wording of compose example ([#​10276](traefik/traefik#10276) by [svx](https://github.com/svx)) - **\[k8s/crd]** Adjust deprecation notice for Kubernetes CRD provider ([#​10317](traefik/traefik#10317) by [rtribotte](https://github.com/rtribotte)) - Fix description for anonymous usage statistics references ([#​10287](traefik/traefik#10287) by [ariyonaty](https://github.com/ariyonaty)) - Documentation enhancements ([#​10261](traefik/traefik#10261) by [svx](https://github.com/svx)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTIuMSIsInVwZGF0ZWRJblZlciI6IjM3LjE1Mi4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Reviewed-on: https://git.mgrote.net/mg/homeserver/pulls/672 Co-authored-by: Renovate Bot <renovate@mgrote.net> Co-committed-by: Renovate Bot <renovate@mgrote.net>
What does this PR do?
This PR adds 2 options to control how we want to close keep alive connection
Motivation
Sometimes, LB in front of Traefik are "stick" to a traefik instance because of keep alive, this feature allow to mitigate this problem by forcing to renew connections.
Fixes #10191
More
Additional Notes
This PR adds a new var in expvar to be able to follow what happens on connections.