Fix tests to prepare for upcoming leaflet v2.2.0 release #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I think thats fine and the order should not matter. |
|
its on cran! |
|
Thanks @trafficonese! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @trafficonese! We're preparing the next release of leaflet (v2.2.0, rstudio/leaflet#876) and noticed that our updates break a test in your package.
I've provided a fix in this PR. In essence,
leaflet()now includes its own dependencies in thedependenciesitem of the returned htmlwidgets object, which means that it contains both our dependencies and the dependencies your extension has added. The updated test now finds the name of all dependencies in the object and ensures thatlfx-movingmarkerandleaflet-awesomemarkersare included. This ensures that they're included in the list of dependencies, but you may want to add an additional check to test that they're included in that order (if that's important to your extension).Do you think you'd be able to update your package on CRAN in the next two weeks? We're planning on submitting leaflet v2.2.0 on Tuesday, August 29 at the latest and are hoping we can have all reverse dependencies issues worked out by then. Thanks!