Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users on the english locales to choose between MM/DD/YYYY and DD/MM/YYYY datetime formating #135

Closed
AbundantSalmon opened this issue Jan 14, 2023 · 0 comments · Fixed by #134
Labels
a:feature New feature or request

Comments

@AbundantSalmon
Copy link
Contributor

AbundantSalmon commented Jan 14, 2023

Is your feature request related to a problem? Please describe.
Currently all datetimes for users of either of the english locales are displayed in the US date format where the leading value is the month, this is annoying and potentially confusing for all other english users where the standard has the leading value as the day. i.e 03/01 can be read as the 3rd of January or the 1st of March.

Describe the solution you'd like
Add a user setting similar to the date locale, to allow english users to set their preferred display date format.

Describe alternatives you've considered
Datetime formats could be not user selectable and be purely inferred from the user's language/locale and use javascript's built in toLocaleString() functionality. The issue is that this removes choice from the user and also would require a large variety of changes in multiple places in the codebase, whereas the above solution allows user choice and utilises the moment library's statefulness and minimises places in the codebase that need to be modified.

Additional context

Examples:

Screenshot 2023-01-14 at 09 14 44

vs

Screenshot 2023-01-14 at 09 15 01

Screenshot 2023-01-14 at 09 16 42

vs

Screenshot 2023-01-14 at 09 16 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant