Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to skip checking dependency crates in the same workspace? #804

Closed
EFanZh opened this issue Aug 22, 2023 · 4 comments
Closed

Comments

@EFanZh
Copy link
Contributor

EFanZh commented Aug 22, 2023

Clippy provides a --no-deps option to do this: rust-lang/rust-clippy#6188. Is is possible to simulate this behavior in dylint?

@EFanZh EFanZh changed the title Is there a way to exclude lints in dependency crates in the same workspace? Is there a way to skip checking dependency crates in the same workspace? Aug 22, 2023
@smoelius
Copy link
Collaborator

smoelius commented Aug 22, 2023

Dylint does not have this feature currently, but we could add it.

I want to be sure I understand the problem that it solves, though. A workspace has two crates, A and B, where A depends on B. B causes some lint to trigger. We want to lint A, and not trigger the lint/see warnings for B. Is that right?

Is having this feature time sensitive?

@EFanZh
Copy link
Contributor Author

EFanZh commented Aug 22, 2023

Yes, that is right. And it is not time sensitive. I can simulate this behavior manually. But it might be reasonable for dylint to support it officially.

@smoelius
Copy link
Collaborator

I'll start working on it this week.

@smoelius
Copy link
Collaborator

smoelius commented Aug 29, 2023

This should be fixed by #808 in version 2.2.0 (just released).

However, it required messing with Cargo caching, which I find especially tricky to get right.

If anything about the new feature doesn't work as you expect, please don't hesitate to re-open this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants