Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent naming in API #147

Closed
yan opened this issue Apr 19, 2017 · 1 comment · Fixed by #530
Closed

Use consistent naming in API #147

yan opened this issue Apr 19, 2017 · 1 comment · Fixed by #530
Labels
easy help wanted ux

Comments

@yan
Copy link
Contributor

yan commented Apr 19, 2017

State.symbolicate_buffer uses the label parameter to tag symbolic values, where as State.new_symbolic_buffer uses name.
@feliam
Copy link
Contributor

feliam commented Apr 19, 2017

Also "symbolicate" sounds (to me) like we are upgrading something to symbolic. When in fact we are overwriting whatever is there (potentially already symbolic data) with a fresh symbols.

@dguido dguido added the ux label Apr 28, 2017
@yan yan mentioned this issue Sep 26, 2017
Closed
@yan yan mentioned this issue Oct 23, 2017
Merged
@yan yan closed this as completed in #530 Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy help wanted ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various bug fixes. trailofbits/manticore
4 participants
@yan @dguido @feliam @offlinemark