Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIIR #186

Open
woodruffw opened this issue May 10, 2023 · 4 comments
Open

RIIR #186

woodruffw opened this issue May 10, 2023 · 4 comments

Comments

@woodruffw
Copy link
Member

I think it's time to consider rewriting this project in Rust: it receives very little maintenance or novel feature development, has had a few memory corruption vulnerabilities discovered through fuzzing over the years, and has a relatively simple C API that could be exposed from a Rust core.

In other words: from an external users' perspective, all that would change is the C API (we'd have to make breaking changes to accommodate internal changes). External users would not need to know Rust.

If we decide to do this, we should do it as a major breaking change, with a new major (3.x) release series.

As part of a potential rewrite, we should reuse an existing high-quality Rust PE parser, rather than writing our own. Two options:

A rewrite here would also have downstream repercussions for a few of our projects, including winchecksec and uthenticode. It's my opinion that those repercussions would be largely positive, although it's still churn that would need to be performed. It would also be a strong motivating point for rewriting some of those projects in Rust as well.

CCing for opinions: @ekilmer @yardenshafir @ret2libc @alessandrogario

@yardenshafir
Copy link
Contributor

I'm ok with this. It might also be a good chance to rewrite some of those downstream projects in rust since they are also mostly static at this point.

@ekilmer
Copy link
Contributor

ekilmer commented May 11, 2023

Agreed, I'm also okay with this.

@TaoTao-real
Copy link

Will there be plans to release a new version after rewriting it in RUST?

@woodruffw
Copy link
Member Author

Will there be plans to release a new version after rewriting it in RUST?

That's the plan, but nobody is currently working on the rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants