Parse local variables prior parsing modifier (fix 99)

crytic · Dec 11, 2018 · a4032dc · a4032dc
1 parent f70fe60
commit a4032dc
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/slither/solc_parsing/declarations/function.py b/slither/solc_parsing/declarations/function.py
@@ -804,11 +804,12 @@ def analyze_content(self):
                 if child[self.get_key()] == 'Block':
                     self._is_implemented = True
                     self._parse_cfg(child)
-                    continue
-
-                assert child[self.get_key()] == 'ModifierInvocation'
-
-                self._parse_modifier(child)
+
+            # Parse modifier after parsing all the block
+            # In the case a local variable is used in the modifier
+            for child in children[2:]:
+                if child[self.get_key()] == 'ModifierInvocation':
+                    self._parse_modifier(child)
 
         for local_vars in self.variables:
             local_vars.analyze(self)