Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Config screen doesn't update #5

Closed
trainb0y opened this issue Oct 13, 2022 · 4 comments
Closed

[BUG] Config screen doesn't update #5

trainb0y opened this issue Oct 13, 2022 · 4 comments
Labels
bug Something isn't working next release This is included in the next release

Comments

@trainb0y
Copy link
Owner

Some values, such as mouse sensitivity, are clamped between certain values. If the player inputs a value outside of that range, it will be clamped to within it. However, the GUI does not update to reflect that, which can cause confusion.

See #4

If possible, this needs to be fixed before the next release.
@trainb0y trainb0y added the bug Something isn't working label Oct 13, 2022
@trainb0y trainb0y changed the title Config screen doesn't update [BUG] Config screen doesn't update Oct 13, 2022
@trainb0y
Copy link
Owner Author

Honestly a better solution would be to implement a SliderOption that makes these options sliders. SpruceUI already has sliders, I'd just need to make an Option for them.

@trainb0y
Copy link
Owner Author

trainb0y commented Oct 13, 2022 •
edited

Might migrate to YACL, but I don’t want this mod to just be worse Zoomify, so I’m hesitant to do that.

There’s also the GUI/config libraries from the Essential mod, that might be worth using. (Edit: it hasn't been updated to 1.19.2 yet)

@trainb0y trainb0y mentioned this issue Oct 16, 2022
Closed
@trainb0y
Copy link
Owner Author

Finished migrating to YACL with e5d8da2

Will be in 1.2.0

@trainb0y trainb0y added the next release This is included in the next release label Oct 17, 2022
@trainb0y
Copy link
Owner Author

https://github.com/trainb0y/FabriZoom/releases/tag/1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working next release This is included in the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trainb0y