Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename 'prepend' macro #208

Open
jrochkind opened this issue Feb 27, 2019 · 0 comments
Open

rename 'prepend' macro #208

jrochkind opened this issue Feb 27, 2019 · 0 comments

Comments

@jrochkind
Copy link
Contributor

It sadly conflicts with the module prepend method, which might cause problems.

Should perhaps be prepend_str, with corresponding change to append=>append_str to match.

Our backwards compatibility concerns suggest it should be deprecated and can't really be removed until a traject 4.0. Is there a way to give anyone that needs to avoid the conflict with module prepend satisfaction sooner? Perhaps, there could be a way to not mix-in those particular macros in an opt-in way.

Whether this is worth the work may depend on someone actually encountering a problem with the method name conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant